Fix CreditMemo migration #112
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GSadee
approved these changes
Feb 7, 2019
|
Thank you, Mateusz! 🥇 |
GSadee
added a commit
that referenced
this pull request
Feb 7, 2019
This PR was merged into the 1.0-dev branch. Discussion ---------- Based on #112 Even though we've been providing migrations with this plugin for a long time, we didn't use them in a Travis CI configuration. And it was a mistake - it resulted in having them out-dated from time to time... and we could not be 100% sure they work 💃 I've copied migration files from `Sylius-Standard` to make it possible to set up a database with `doctrine:migrations:migrate` rather than `doctrine:schema:create`. And of course it kind of unnecessary code in a `tests/Application`, but on the other hand, this test application should simulate a **Sylius-Standard** app which is using a `RefundPlugin`. And, as we know, each **Sylius-Standard** app is provided with a bunch of migrations inside 🐃 🏇 Commits ------- 168b447 Use migrations in Travis CI
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There were some problems, it was incomplete and wrongly configured... so I've created it one more time from scratch, it should work fine :)